gtkplus : edited patch to fix macos darwin build fail#5093
Open
foglienimatteo wants to merge 3 commits into
Open
gtkplus : edited patch to fix macos darwin build fail#5093foglienimatteo wants to merge 3 commits into
foglienimatteo wants to merge 3 commits into
Conversation
involuntaly added non-related package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS with Darwin Tahoe, the istallation of gtkplus fails:
sincosis not defined without_DARWIN_C_SOURCE. Fix: injection of a static inline definition (an alternative would be to suppress test compilation with-Dtests=false)Objective-C syntax (@-directives) are not interpreted in
-std=c99, andgtksearchengine.creferencing_gtk_search_engine_quartz_new()make the linker fails with undefined symbol. Fix: replace of the function with a minimal C stub returning NULL (not the best fix I admit, open for improvements)